Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix index_lookup_hash_join hang when used with limit #35820

Merged
merged 5 commits into from
Jul 11, 2022
Merged

executor: fix index_lookup_hash_join hang when used with limit #35820

merged 5 commits into from
Jul 11, 2022

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Jun 29, 2022 •
edited
Loading

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #35638

Problem Summary:
IndexLookupHashJoin hangs when used with limit.

innerWorker of IndexLookupHashJoin is still running when limitExec calls Close(). So no goroutine will read result, which makes the task.resultCh be full, and it's stucked when innerWorker try to push result.

What is changed and how it works?

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

executor: fix index_lookup_hash_join hang when used with limit

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • XuHuaiyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2022
@guo-shaoge
fix index_lookup_hash_join hang when used with limit
ef0716b 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 29, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 29, 2022
@guo-shaoge guo-shaoge changed the title fix index_lookup_hash_join hang when used with limit executor: fix index_lookup_hash_join hang when used with limit Jun 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 29, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2e5a10135e416c624ebee84f01433155f13573f6

@guo-shaoge guo-shaoge requested a review from XuHuaiyu July 7, 2022 10:26
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2022
@guo-shaoge
use mysql_test as case
1392868 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
guo-shaoge
guo-shaoge commented Jul 11, 2022
View reviewed changes
executor/index_lookup_hash_join.go
@@ -608,7 +608,10 @@ func (iw *indexHashJoinInnerWorker) handleTask(ctx context.Context, task *indexH
if task.keepOuterOrder {
if err != nil {
joinResult.err = err
resultCh <- joinResult
select {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add mysql test as case: https://github.com/pingcap/tidb-test/pull/1887

@guo-shaoge guo-shaoge requested a review from wshwsh12 July 11, 2022 08:27
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2022
@guo-shaoge
Copy link
Collaborator Author

/run-all-tests

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-5.0
7495b06 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #36098

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-5.1
5f65b8a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36099

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-5.2
bf17ddf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36100

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-5.3
c45664b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36101

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-5.4
a43eef5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36102

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-6.0
4c41912 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36103

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 11, 2022
@guo-shaoge @ti-srebot
cherry pick pingcap#35820 to release-6.1
6c9ac8f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36104

@sre-bot
Copy link
Contributor

sre-bot commented Jul 11, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test ✅ all 36 tests passed 25 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 16 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 25 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 16 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 37 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 6 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2022
@ti-srebot
executor: fix index_lookup_hash_join hang when used with limit (#35820)…
6e9fd42 
… (#36104)

close #35638
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2022
@ti-srebot
executor: fix index_lookup_hash_join hang when used with limit (#35820)…
742f361 
… (#36101)

close #35638
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2022
@ti-srebot
executor: fix index_lookup_hash_join hang when used with limit (#35820)…
221cb88 
… (#36099)

close #35638
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2022
@ti-srebot
executor: fix index_lookup_hash_join hang when used with limit (#35820)…
23ab34a 
… (#36098)

close #35638
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2022
@ti-srebot
executor: fix index_lookup_hash_join hang when used with limit (#35820)…
5025a35 
… (#36100)

close #35638
ti-chi-bot pushed a commit that referenced this pull request Jul 14, 2022
@ti-srebot
executor: fix index_lookup_hash_join hang when used with limit (#35820)…
ef81f12 
… (#36102)

close #35638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@AilinKid AilinKid AilinKid approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

indexHashJoin hang in handleTask
6 participants
@guo-shaoge @ti-chi-bot @sre-bot @ti-srebot @XuHuaiyu @AilinKid