Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update client-go to improve availability on tikv failure #35561

Merged
merged 2 commits into from
Jun 22, 2022
Merged

*: update client-go to improve availability on tikv failure #35561

merged 2 commits into from
Jun 22, 2022

Conversation

sticnarf
Copy link
Contributor

Signed-off-by: Yilin Chen sticnarf@gmail.com

What problem does this PR solve?

Issue Number: close #34906

What is changed and how it works?

See tikv/client-go#503

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Prevent sending requests to unhealthy TiKV nodes to improve availability.

@sticnarf
*: update client-go to improve availability on tikv failure
070c592 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ngaut
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2022
@sticnarf
fix unit test
46a2f99 
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@xhebox
Copy link
Contributor

xhebox commented Jun 22, 2022

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 22, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/46a2f99789b50a3f63fae2a893ea726c91a506aa

xhebox
xhebox approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2022
@xhebox
Copy link
Contributor

xhebox commented Jun 22, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 46a2f99

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 22, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 22, 2022
@ti-chi-bot ti-chi-bot merged commit d4b5838 into pingcap:release-5.4 Jun 22, 2022
@heibaijian heibaijian added this to the v5.4.2 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v5.4.2
Development

Successfully merging this pull request may close these issues.
7 participants
@sticnarf @ti-chi-bot @xhebox @sre-bot @ngaut @VelocityLight @heibaijian