Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config, sysvar: add config
instance.enable_ddl
and sysvartidb_enable_ddl
#35425config, sysvar: add config
instance.enable_ddl
and sysvartidb_enable_ddl
#35425Changes from 26 commits
8946074
cd2a367
1093e31
d2ed88e
1936c53
90038dc
ebc7c77
54d85fb
a022b50
64f9066
f2cb35d
21adce6
28ea9dd
7025f05
7f8a81f
cdfeb02
e598dae
911688c
3e66acd
34d79e0
9d3cb45
13264ba
bd11972
0d97a9f
aeb9291
d0cc647
0c88942
40802ed
78733d7
1bb0c46
d2ab14c
27bd71f
70111de
f47dd96
c22fa7a
5f2c12e
af356cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also passed the parameter
ctx
towatchOwner
. Could we remove this logic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it. Now a
ctx
ofManager
itself is passed in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not what I meant. The
CampaignCancel()
is executed. We passedctx
inCampaign
andwatchOwner
, so I think we will quit the owner campaign. So we don't need those lines of logic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use
d.ownerManager.Cancel()
directly? Then we can removeCampaignCancel
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d.ownerManager.Cancel()
would cancel theownerManager
, butCampaignCancel
only breaks a campaign.