Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/design: add index acceleration #35196

Merged
merged 13 commits into from
Sep 16, 2022
Merged

docs/design: add index acceleration #35196

merged 13 commits into from
Sep 16, 2022

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Jun 7, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:

What is changed and how it works?

This is a pr to new design doc of add index acceleration.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 7, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1ece379562a11820ea86c24319c57cfd97fbc76a

@Benjamin2037 Benjamin2037 force-pushed the design_doc_pr branch 2 times, most recently from 0fb8889 to caa4be5 Compare July 20, 2022 02:24
@tangenta tangenta mentioned this pull request Aug 1, 2022
Closed
20 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2022
@tangenta tangenta changed the title Document: Add design doc for Add index acceleration. docs/design: add index acceleration Sep 16, 2022
Benjamin2037 and others added 2 commits September 16, 2022 14:22
@Benjamin2037 @zimulala
Update docs/design/2022-06-06-Adding-Index-Acceleration.md
9a2f7ae 
Co-authored-by: Lynn <zimu_xia@126.com>
bb7133
bb7133 approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2022
@bb7133
Copy link
Member

bb7133 commented Sep 16, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fe9629f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 886d29d into pingcap:master Sep 16, 2022
@Benjamin2037 Benjamin2037 deleted the design_doc_pr branch September 16, 2022 07:54
@sre-bot
Copy link
Contributor

sre-bot commented Sep 16, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 52 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 24 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 8 min 57 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 25 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 9 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 34 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 5 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 53 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 approved these changes

@tangenta tangenta tangenta approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Benjamin2037 @ti-chi-bot @sre-bot @bb7133 @morgo @zimulala @tangenta