Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support SHOW TABLE STATUS with case insensitivity #35086

Merged
merged 10 commits into from
Jun 1, 2022
Merged

*: support SHOW TABLE STATUS with case insensitivity #35086

merged 10 commits into from
Jun 1, 2022

Conversation

likzn
Copy link
Contributor

@likzn likzn commented May 31, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7518

Problem Summary: Support SHOW TABLE STATUS with case insensitivity

What is changed and how it works?

  1. *: add show push down for ShowTables #31919 has implemented core logic, to introduce it to support the statement of SHOW TABLE STATUS with case insensitivity.
  2. Make some refactor to eliminate duplicate code, make code clean.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support statement of `SHOW TABLE STATUS` with case insensitivity

likzn added 3 commits May 31, 2022 21:24
@likzn
fix table status
f6434b8
@likzn
Merge branch 'master' into fix_show_table_status
15ab670 
# Conflicts:
#	executor/show.go
#	planner/core/planbuilder.go
#	planner/core/show_predicate_extractor.go
@likzn
refactor
287e574
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2022
@morgo morgo requested a review from hawkingrei May 31, 2022 15:01
@sre-bot
Copy link
Contributor

sre-bot commented May 31, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ba31db9c8a781752f2a7372d0f1be2e15a965685

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
@hawkingrei
Copy link
Member

/run-build

@hawkingrei
Copy link
Member

@likzn You need to fix some conflict caused by #35089 to fix the show collation.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
likzn added 2 commits June 1, 2022 13:49
@likzn
Merge branch 'master' into fix_show_table_status
0d1c93f 
# Conflicts:
#	executor/show_test.go
#	planner/core/planbuilder.go
#	planner/core/show_predicate_extractor.go
#	planner/core/stringer_test.go
@likzn
resolve conflict
d07a65a
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@likzn
Copy link
Contributor Author

likzn commented Jun 1, 2022

@likzn You need to fix some conflict caused by #35089 to fix the show collation.

Done

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d07a65a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@likzn
Copy link
Contributor Author

likzn commented Jun 1, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit c133e74 into pingcap:master Jun 1, 2022
@hawkingrei hawkingrei added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Jun 1, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 1, 2022
@likzn @ti-srebot
cherry pick pingcap#35086 to release-6.1
f714c9f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 1, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35115

@likzn likzn deleted the fix_show_table_status branch June 6, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHOW TABLE STATUS case sensitivity
6 participants
@likzn @ti-chi-bot @sre-bot @hawkingrei @xiongjiwei @ti-srebot