-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: move config file option committer-concurrency to sysvar #34368
*: move config file option committer-concurrency to sysvar #34368
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a4da22c9db40d4f6befef04ca6d54ec483e2e0a6 |
Please review @morgo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sysvar/config changes LGTM, but I'll find a tikv reviewer so we can make sure the change is working correctly.
/run-check_dev_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this PR LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And why remove go.sum
?
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 39905d4
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a4da22c
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: ref #33769
Problem Summary:
The option
committer-concurrency
has historically been a config option. Based on requirements from cloud & PM it should instead be aGLOBAL
sysvar.What is changed and how it works?
This PR converts the option
committer-concurrency
to a global (cluster-wide) sysvartidb-committer-concurrency
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.