Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: preprocessor add CTE recursive check when handleTableName #34133

Merged
merged 19 commits into from
May 6, 2022
Merged

planner: preprocessor add CTE recursive check when handleTableName #34133

merged 19 commits into from
May 6, 2022

Conversation

likzn
Copy link
Contributor

@likzn likzn commented Apr 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #34090

Problem Summary: When we use non recursive CTE, if the table name is the same as WITH name.The preprocessor will not add schema in the table name. So we need a check judge it if it is recursive. Add schema if it is non recursive, don't add if it is recursive

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2022
@likzn
Copy link
Contributor Author

likzn commented Apr 20, 2022

/cc @tangenta @xhebox PTAL if free

@ti-chi-bot
Copy link
Member

@likzn: GitHub didn't allow me to request PR reviews from the following users: PTAL, if, free.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tangenta @xhebox PTAL if free

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@likzn likzn marked this pull request as draft April 20, 2022 12:38
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@likzn likzn marked this pull request as ready for review April 20, 2022 16:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
winoros
winoros previously approved these changes Apr 20, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2022
@winoros
Copy link
Member

winoros commented Apr 20, 2022

Oh
your change caused a panic in other tests
https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/46615/pipeline/

@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/5b9aa624f354d4c9bce997d7f99c65ff59ddddb3

@likzn
Copy link
Contributor Author

likzn commented Apr 21, 2022

Oh your change caused a panic in other tests https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/46615/pipeline/

My mistake. Fixed.

wjhuang2016
wjhuang2016 reviewed Apr 21, 2022
View reviewed changes
planner/core/preprocess.go Outdated Show resolved Hide resolved
planner/core/preprocess_test.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Apr 21, 2022
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave some format suggestions.

planner/core/preprocess.go Outdated Show resolved Hide resolved
planner/core/preprocess.go Outdated Show resolved Hide resolved
planner/core/preprocess.go Outdated Show resolved Hide resolved
planner/core/preprocess_test.go Outdated Show resolved Hide resolved
planner/core/preprocess_test.go Outdated Show resolved Hide resolved
planner/core/preprocess_test.go Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor

https://gist.github.com/tangenta/59656073b91a33f7cb0441e598da245a

@likzn I try to write a more intuitive test for the Preprocess(), please check if you can add it to your PR.

@tangenta tangenta mentioned this pull request Apr 21, 2022
Merged
12 tasks
@likzn
Copy link
Contributor Author

likzn commented Apr 21, 2022

https://gist.github.com/tangenta/59656073b91a33f7cb0441e598da245a

@likzn I try to write a more intuitive test for the Preprocess(), please check if you can add it to your PR.

It is so intuitive. But now i rely the make explaintest to test(There are many CTE cases).Maybe i can construct a before sql, but how can i ensure the after sql is correct.I afraid the change can run but it not work with our expection.

@likzn
Copy link
Contributor Author

likzn commented May 5, 2022

@tangenta @winoros PTAL. Code has some change

tangenta
tangenta reviewed May 6, 2022
View reviewed changes
bindinfo/handle.go Outdated Show resolved Hide resolved
@likzn @tangenta
Update bindinfo/handle.go
76a691a 
Co-authored-by: tangenta <tangenta@126.com>
@likzn
Copy link
Contributor Author

likzn commented May 6, 2022

/run-all

@likzn
Copy link
Contributor Author

likzn commented May 6, 2022

/run-unit-test

@tangenta
Copy link
Contributor

tangenta commented May 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bcc7508

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@ti-chi-bot ti-chi-bot merged commit fa5e190 into pingcap:master May 6, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@likzn @ti-srebot
cherry pick pingcap#34133 to release-5.1
b74d33a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #34411

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@likzn @ti-srebot
cherry pick pingcap#34133 to release-5.2
8e6c23d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #34412

@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #34413

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@likzn @ti-srebot
cherry pick pingcap#34133 to release-5.4
2276240 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34414

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 6, 2022
@likzn @ti-srebot
cherry pick pingcap#34133 to release-6.0
e0cbc24 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 6, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34415

@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 43 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 9 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 10 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 18 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 56 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 38 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

xhebox pushed a commit to ti-srebot/tidb that referenced this pull request Aug 10, 2022
@likzn @xhebox
cherry pick pingcap#34133 to release-5.3
e78dac5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@tangenta tangenta tangenta approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"references invalid table" when show columns from view
7 participants
@likzn @ti-chi-bot @winoros @sre-bot @tangenta @wjhuang2016 @ti-srebot