Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: stabalize TestSelectClusterTable test #33295

Merged
merged 1 commit into from
Mar 22, 2022
Merged

infoschema: stabalize TestSelectClusterTable test #33295

merged 1 commit into from
Mar 22, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 21, 2022

What problem does this PR solve?

Issue Number: close #33294

Problem Summary:

The infoschema tests are unstable. This is caused by the HOST portion of the processlist now including the peer port (from #30183 ). The solution is just to not include this in the results.

What is changed and how it works?

Fixed tests only.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@morgo morgo requested a review from mjonss March 21, 2022 15:47
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 21, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b0cdbbf00166fedda30ba30d1107c2b2413f60ef

mjonss
mjonss approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0cdbbf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2022
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot merged commit 6c28e0e into pingcap:master Mar 22, 2022
@morgo morgo deleted the stabalize-infoschema-tests branch March 22, 2022 20:56
@qw4990
Copy link
Contributor

qw4990 commented Mar 24, 2022

/cherry-pick release-6.0

@ti-srebot ti-srebot mentioned this pull request Mar 24, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 24, 2022
@morgo @ti-srebot
cherry pick pingcap#33295 to release-6.0
cdfc543 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33366

ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2022
@ti-srebot
infoschema: stabalize TestSelectClusterTable test (#33295) (#33366)
310fe55 
close #33294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestSelectClusterTable test is unstable
7 participants
@morgo @ti-chi-bot @sre-bot @hawkingrei @qw4990 @ti-srebot @mjonss