-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression, types: use time.Add() to calculate subtime #32903
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/451bf09cd1d4e920754f540e9a1dc69917601242 |
/run-check_dev_2 |
/run-unit-test |
1 similar comment
/run-unit-test |
/cc @hawkingrei @tangenta @xhebox |
if err != nil { | ||
return "", false, err | ||
} | ||
tmpDuration := arg0.Sub(sc, &arg1time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will cause overflow, so use time.Add
instead of it.
/cc @tiancaiamao |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 313f055
|
/run-unit-test |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #33125 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #33126 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #33127 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.3 in PR #33128 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.4 in PR #33129 |
What problem does this PR solve?
Issue Number: close #31868
Problem Summary:
The
time.sub()
will cause overflow when the gap with duration greatter than 290 years, so usetime.add()
instead of it. Open a new issue to trace improvetime
type #32937What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note