Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: migrate test-infra to testify for db_change_test.go #32651

Merged
merged 2 commits into from
Feb 28, 2022
Merged

ddl: migrate test-infra to testify for db_change_test.go #32651

merged 2 commits into from
Feb 28, 2022

Conversation

tisonkun
Copy link
Contributor

Issue Number: close #28633

None

@tisonkun
ddl: migrate test-infra to testify for db_change_test.go
995d24f 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2022
@tisonkun
Copy link
Contributor Author

/cc @hawkingrei @xhebox @djshow832

@tisonkun
Copy link
Contributor Author

@tiancaiamao can you reproduce test failure of unit-test locally? I don't run into failure locally on the changes, or it may take some time but exceed the timeout settings.

@tisonkun
Copy link
Contributor Author

/run-unit-test

@tisonkun
Copy link
Contributor Author

TestStateChange really takes near 2 minutes in my local env so it's possible exceed the timeout of settings. But it's a suite contains multiple subtests and each of them take no more than a few of seconds to finish. I don't know whether the timeout killer kills it incorrectly.

@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1ed9a80b1df8b51b5c4b271143ba9c06045768c0

@tisonkun
Copy link
Contributor Author

rerun works =。=

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 28, 2022
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 995d24f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2022
@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit db17bb1 into pingcap:master Feb 28, 2022
@tisonkun tisonkun deleted the issue-28633 branch February 28, 2022 07:17
@zimulala zimulala mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

@xhebox xhebox Awaiting requested review from xhebox

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for ddl/db_change_test.go
5 participants
@tisonkun @ti-chi-bot @sre-bot @xiongjiwei @hawkingrei