Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support prepared plan cache for cached table #32139

Merged
merged 8 commits into from
Feb 14, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Feb 7, 2022

What problem does this PR solve?

Issue Number: close #32003

Problem Summary:

Make the cached table been able to use prepared plan cache.
Without plan cache, the performance decrease too much and counteract the benefit from table caching.

What is changed and how it works?

In the past, whether to read from table cache is decided in the logical plan optimize phase.
If the cache data is available, a UnionScan is added as the parent plan.

The problem of that implementation is, with / wo table cache, the generated plan is different.
That means the plan can't be reused (the shape of the plan may change)

In this PR, to leverage prepared plan cache, I defer the UnionScan generation to the executor phase.
In executor.build(), if table cache is available, TableReader will be changed to UnionScan->TableReader.

Most of the test code changes are unrelated...
Before this PR, we use "explain select ..." and check the UnionScan to verify that the table cache data is used.
Now we can't do that because there will be no UnionScan in explain result any more.
So the test code is updated.

Another unrelated change is that the "Cannot use IndexMerge on TableCache." warning is gone.
I don't mean to do that but since the code logic change, the restriction is temporarily removed.
There is already an issue for it #29682 and I'll fix later.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Feb 7, 2022

executor/builder.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 12ece11

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022
@ti-chi-bot
Copy link
Member

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor Author

/merge

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 1cf4fcf into pingcap:master Feb 14, 2022
@tiancaiamao tiancaiamao deleted the plancache-cached-table branch February 17, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cached table can't use prepare plan cache, that's not acceptable!
5 participants