Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix greatest and least function with collation get wrong result #31806

Merged
merged 8 commits into from
Jan 20, 2022
Merged

expression: fix greatest and least function with collation get wrong result #31806

merged 8 commits into from
Jan 20, 2022

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Jan 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #31789

when deriving collation from expression, greatest and least function are missed, then they will use the connection_collation as the collation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

fix greatest and least function with collation get wrong result

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 19, 2022
@xiongjiwei xiongjiwei added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 19, 2022
bb7133
bb7133 reviewed Jan 19, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case from #31789

tangenta
tangenta approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to add an integration test.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 19, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2022
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 76d00c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 19, 2022
@xiongjiwei
Copy link
Contributor Author

/run-check_dev

@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@hawkingrei
Copy link
Member

Please add comments for this test case.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@xiongjiwei xiongjiwei removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2022
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 088378f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei
Copy link
Contributor Author

/run-unit-test

1 similar comment
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jan 20, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/182eadbfb7820e7aea503abc5eaaa8b39a95335d

@ti-chi-bot ti-chi-bot merged commit fa3328f into pingcap:master Jan 20, 2022
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
4 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@xiongjiwei @ti-srebot
cherry pick pingcap#31806 to release-5.3
846fb40 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31837

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@xiongjiwei @ti-srebot
cherry pick pingcap#31806 to release-5.4
d9e007a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31838

ti-chi-bot pushed a commit that referenced this pull request Feb 22, 2022
@ti-srebot
expression: fix greatest and least function with collation get wrong …
b3db409 
…result (#31806) (#31837)

close #31789
ti-chi-bot pushed a commit that referenced this pull request Apr 28, 2022
@ti-srebot
expression: fix greatest and least function with collation get wrong …
73cec93 
…result (#31806) (#31838)

close #31789
@xiongjiwei xiongjiwei deleted the greatest branch September 23, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@Defined2014 Defined2014 Defined2014 approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

greatest() sql function uses connection collation and not collation of columns
9 participants
@xiongjiwei @ti-chi-bot @hawkingrei @sre-bot @ti-srebot @bb7133 @wjhuang2016 @Defined2014 @tangenta