Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: fix function as identifier in TiDB is not compatible with Mysql #31803

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented Jan 19, 2022

What problem does this PR solve?

Issue Number: close #30556

Problem Summary:
Although MySQL declares in https://dev.mysql.com/doc/refman/8.0/en/function-resolution.html that the functions are recognized as functions for create table x(), 4 of them are still recognized as functions:

  • ADDDATE and SUBDATE
  • SESSION_USER and SYSTEM_USER

Which makes TiDB incompatible with MySQL.

For the case of select x (), it's complicated: TiDB won't report errors for some of them but MySQL does. This incompatibility won't bring any problems. Instead, if we change it, it will break compatibility.

What is changed and how it works?

  • Remove the 4 functions from btFuncTokenMap
  • Remove builtinAddDate and builtinSubDate

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2022
@djshow832
Copy link
Contributor Author

What do you think of it? Do we merge this PR or do we just update the MySQL tests in the issue? @morgo @tangenta

@sre-bot
Copy link
Contributor

sre-bot commented Jan 19, 2022

@morgo
Copy link
Contributor

morgo commented Jan 19, 2022

What do you think of it? Do we merge this PR or do we just update the MySQL tests in the issue? @morgo @tangenta

LGTM. It is hard to predict users with reserved words, so I think it is worth making it more compatible.

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 20, 2022
@bb7133
Copy link
Member

bb7133 commented Jan 20, 2022

PTAL @morgo

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 20, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2022
@djshow832
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0a4be4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 28, 2022
@ti-chi-bot ti-chi-bot merged commit 2a5e480 into pingcap:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function as identifier in Tidb is not compatible with Mysql(5.7 and 8.0)
5 participants