Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, table: Disallow update self (natural) join on partitioning columns (#31629) #31779

Merged
merged 8 commits into from
Feb 18, 2022
Merged

planner, table: Disallow update self (natural) join on partitioning columns (#31629) #31779

merged 8 commits into from
Feb 18, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Jan 18, 2022

What problem does this PR solve?

Issue Number: close #31629

Problem Summary:
Self natural join was allowed on partitioning columns, resulting in UPDATE could even duplicate rows.

What is changed and how it works?

Dissallow update for natural joins containing partitioning columns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Disallowing update on self natural join on partitioning columns.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 18, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4f37561869f1efbcc43147e74683be75a6c3335c

@qw4990 qw4990 self-requested a review January 19, 2022 11:36
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 21, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Jan 25, 2022

Please also test something like:
UPDATE t2 SET a='aaa' where a in (SELECT a from t2); which should not be allowed.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Jan 27, 2022

Please also test something like: UPDATE t2 SET a='aaa' where a in (SELECT a from t2); which should not be allowed.

That will be reported as a separate bug, since it seems to be allowed also for non-partitioned tables.

@mjonss
Copy link
Contributor Author

mjonss commented Jan 27, 2022

/cc @qw4990 do you have time to review this?

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ceeea0a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2022
@ti-chi-bot ti-chi-bot merged commit 313960e into pingcap:master Feb 18, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 18, 2022
@mjonss @ti-srebot
cherry pick pingcap#31779 to release-4.0
e61d430 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #32471

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 18, 2022
@mjonss @ti-srebot
cherry pick pingcap#31779 to release-5.0
f556c0f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #32472

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 18, 2022
@mjonss @ti-srebot
cherry pick pingcap#31779 to release-5.1
5ffaaf2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #32473

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 18, 2022
@mjonss @ti-srebot
cherry pick pingcap#31779 to release-5.2
f3db022 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #32474

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 18, 2022
@mjonss @ti-srebot
cherry pick pingcap#31779 to release-5.3
e1771c0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #32475

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 18, 2022
@mjonss @ti-srebot
cherry pick pingcap#31779 to release-5.4
513eabc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Feb 18, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #32476

@qw4990
Copy link
Contributor

qw4990 commented Feb 21, 2022

/cc @qw4990 do you have time to review this?

I reviewed these file changes, it's LGTM.

@mjonss mjonss deleted the issue-31629 branch February 21, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiDB Update with Natural join on Partitioned table results are not consistent with mysql.
7 participants
@mjonss @ti-chi-bot @sre-bot @tiancaiamao @ti-srebot @qw4990 @djshow832