Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix load data panic if the data is broken at escape character (#30868) #31773

Merged
merged 4 commits into from
Mar 2, 2022
Merged

executor: fix load data panic if the data is broken at escape character (#30868) #31773

merged 4 commits into from
Mar 2, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 18, 2022 •
edited
Loading

cherry-pick #30868 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/31773

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/31773:release-5.3-65365628b7e2

What problem does this PR solve?

Issue Number: close #31589

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

fix load data will panic in some case

@xiongjiwei @ti-srebot
cherry pick pingcap#30868 to release-5.3
1c22d2e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 18, 2022
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick labels Jan 18, 2022
@ti-srebot ti-srebot mentioned this pull request Jan 18, 2022
Merged
4 tasks
@ti-srebot
Copy link
Contributor Author

@xiongjiwei you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

@xiongjiwei please remember to fix the conflicts.

@xiongjiwei
Copy link
Contributor

/cc @youjiali1995 @Defined2014

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2022
@guo-shaoge
Copy link
Collaborator

/run-check_dev
/run-mysql-test

@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 79f5515

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 2, 2022
@guo-shaoge
Copy link
Collaborator

/run-check_dev

2 similar comments
@guo-shaoge
Copy link
Collaborator

/run-check_dev

@guo-shaoge
Copy link
Collaborator

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 459917c into pingcap:release-5.3 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

@jackysp jackysp Awaiting requested review from jackysp

@zimulala zimulala Awaiting requested review from zimulala

Assignees

@xiongjiwei xiongjiwei

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @guo-shaoge @xiongjiwei @youjiali1995 @Defined2014 @zhouqiang-cl