Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: support column range partition pruning for builtin function IN #31493

Merged
merged 14 commits into from
Jan 20, 2022
Merged

planner: support column range partition pruning for builtin function IN #31493

merged 14 commits into from
Jan 20, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 10, 2022

What problem does this PR solve?

Issue Number: close #26739

Problem Summary: planner: support column range partition pruning for builtin function IN

What is changed and how it works?

Convert IN to EQ and then prune them.

Check List

Tests

  • Unit test

Release note

planner: support column range partition pruning for builtin function IN

@qw4990 qw4990 added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 10, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ece0ada7825b45f1cfa539c56f81157383e7b557

@qw4990 qw4990 requested a review from rebelice January 10, 2022 06:24
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2022
@sultan8252
Copy link

👍

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 13, 2022

PTAL @Reminiscent

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 17, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 17, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 20, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2abaa8a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 20, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 20, 2022

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jan 20, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit a15f4fd into pingcap:master Jan 20, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@qw4990 @ti-srebot
cherry pick pingcap#31493 to release-5.0
fcb1a23 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #31861

@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #31862

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@qw4990 @ti-srebot
cherry pick pingcap#31493 to release-5.1
0c65e9d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@qw4990 @ti-srebot
cherry pick pingcap#31493 to release-5.2
71be642 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #31863

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@qw4990 @ti-srebot
cherry pick pingcap#31493 to release-5.3
c1d4282 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #31864

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jan 20, 2022
@qw4990 @ti-srebot
cherry pick pingcap#31493 to release-5.4
9c39e12 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jan 20, 2022
Open
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #31865

ti-chi-bot pushed a commit that referenced this pull request Feb 10, 2022
@ti-srebot
planner: support column range partition pruning for builtin function …
ca51058 
…IN (#31493) (#31862)

close #26739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

operator 'in' partition pruning doesn't take effect on date partition key
7 participants
@qw4990 @ti-chi-bot @sre-bot @sultan8252 @ti-srebot @rebelice @Reminiscent