topsql: make topsql enable only be controlled by pub/sub sink #31209

crazycs520 · 2021-12-31T03:33:10Z

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

make topsql enable only be controlled by pub/sub sink

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Release note

None

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot · 2021-12-31T03:33:11Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

breeswish
tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2021-12-31T03:42:12Z

@zhongzc: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

breezewish

The rest LGTM

sessionctx/variable/sysvar.go

util/topsql/state/state.go

breezewish · 2021-12-31T05:06:30Z

You have made a mistake that the variable and state share the same default value. However they are totally different things so that they should have different constants for controlling the default value.

crazycs520 · 2021-12-31T05:40:10Z

You have made a mistake that the variable and state share the same default value. However they are totally different things so that they should have different constants for controlling the default value.

Nice catch! resolved.

Signed-off-by: crazycs520 <crazycs520@gmail.com>

bb7133 · 2021-12-31T05:53:33Z

/merge

ti-chi-bot · 2021-12-31T05:53:36Z

This pull request has been accepted and is ready to merge.

Commit hash: 0f2d081

zhouqiang-cl · 2021-12-31T06:18:16Z

/merge

breezewish · 2021-12-31T06:37:02Z

@crazycs520 The unit test is failed. Please fix it.

Signed-off-by: crazycs520 <crazycs520@gmail.com>

crazycs520 · 2021-12-31T06:38:57Z

/merge

ti-chi-bot · 2021-12-31T06:39:01Z

This pull request has been accepted and is ready to merge.

Commit hash: fa1246b

executor/set_test.go

Signed-off-by: crazycs520 <crazycs520@gmail.com>

…to topsql-enable

crazycs520 · 2021-12-31T06:45:44Z

/merge

ti-chi-bot · 2021-12-31T06:45:47Z

This pull request has been accepted and is ready to merge.

Commit hash: 75b04d9

Signed-off-by: crazycs520 <crazycs520@gmail.com>

crazycs520 · 2021-12-31T07:03:56Z

/merge

ti-chi-bot · 2021-12-31T07:04:00Z

This pull request has been accepted and is ready to merge.

Commit hash: 4bfbd23

zhouqiang-cl · 2021-12-31T07:18:51Z

/merge

ti-chi-bot · 2021-12-31T07:19:08Z

@crazycs520: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2021-12-31T07:20:04Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/83ae59ea835e81d2fab3b6f1ab23e3608688f9bc

crazycs520 · 2021-12-31T07:38:33Z

/run-unit-test

zhouqiang-cl · 2021-12-31T07:51:51Z

/run-unit-test

crazycs520 · 2021-12-31T07:56:15Z

/merge

crazycs520 · 2021-12-31T08:09:00Z

/merge

crazycs520 · 2021-12-31T08:15:58Z

/merge

ti-chi-bot · 2021-12-31T08:27:40Z

[FORMAT CHECKER NOTIFICATION]

Notice: Please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

crazycs520 · 2021-12-31T08:27:45Z

/merge

* topsql: make topsql enable only be controlled by pub/sub sink (pingcap#31209) * ddl: support batch create table (pingcap#28763) * executor: fix data race in IndexMergeReaderExec (pingcap#31230) close pingcap#31229 * server: filter the EOF error for normal closed at handshake (pingcap#31081) close pingcap#31063 * expression: change date add function return type (pingcap#28133) close pingcap#27573 * support create interval partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * support create interval partition (support int/timestamp partition key) Signed-off-by: crazycs520 <crazycs520@gmail.com> * parser: support alter table partitions move engine statement Signed-off-by: crazycs520 <crazycs520@gmail.com> * support ddl operation Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager handle job framwork Signed-off-by: crazycs520 <crazycs520@gmail.com> * support auto create interval partition when insert meet no partition suitable error Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix bug Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix cancel job and load old job then continue to do Signed-off-by: crazycs520 <crazycs520@gmail.com> * make partition readonly work(not allow to insert/update/delete) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add begin,end time in tables Signed-off-by: crazycs520 <crazycs520@gmail.com> * tiny fix for auto create interval partition in concurrent case Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * todo: remove flag Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix dumpling Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove data in aws s3 when drop/truncate table/partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * make hello world work Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove debug info Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com> Co-authored-by: guo-shaoge <shaoge1994@163.com> Co-authored-by: knull-cn <hu__haifeng@163.com> Co-authored-by: Meng Xin <tregoldmeng@gmail.com>

crazycs520 added 2 commits December 31, 2021 11:20

topsql: make topsql enable only be controlled by pub/sub sink

c695bf1

Signed-off-by: crazycs520 <crazycs520@gmail.com>

refine test

6e40915

Signed-off-by: crazycs520 <crazycs520@gmail.com>

crazycs520 requested a review from a team as a code owner December 31, 2021 03:33

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2021

Merge branch 'master' into topsql-enable

821fc84

zhongzc approved these changes Dec 31, 2021

View reviewed changes

breezewish approved these changes Dec 31, 2021

View reviewed changes

sessionctx/variable/sysvar.go Outdated Show resolved Hide resolved

util/topsql/state/state.go Outdated Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021

address comment

8881f5e

Signed-off-by: crazycs520 <crazycs520@gmail.com>

breezewish approved these changes Dec 31, 2021

View reviewed changes

tangenta approved these changes Dec 31, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 31, 2021

Merge branch 'master' into topsql-enable

0f2d081

bb7133 approved these changes Dec 31, 2021

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

Merge branch 'master' into topsql-enable

ac6471c

fix test

1c3249b

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

Merge branch 'master' into topsql-enable

fa1246b

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

breezewish reviewed Dec 31, 2021

View reviewed changes

executor/set_test.go Outdated Show resolved Hide resolved

crazycs520 added 2 commits December 31, 2021 14:45

update test comment

82c1ec4

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Merge branch 'topsql-enable' of https://github.com/crazycs520/tidb in…

75b04d9

…to topsql-enable

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

fix test

a3f7178

Signed-off-by: crazycs520 <crazycs520@gmail.com>

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

Merge branch 'master' into topsql-enable

4bfbd23

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

Merge branch 'master' into topsql-enable

be0ce88

Merge branch 'master' into topsql-enable

16c494e

Merge branch 'master' into topsql-enable

83ae59e

crazycs520 merged commit 974b578 into pingcap:master Dec 31, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

topsql: make topsql enable only be controlled by pub/sub sink #31209

topsql: make topsql enable only be controlled by pub/sub sink #31209

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021 •

edited

Loading

ti-chi-bot commented Dec 31, 2021

breezewish left a comment

breezewish commented Dec 31, 2021 •

edited

Loading

crazycs520 commented Dec 31, 2021

bb7133 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

zhouqiang-cl commented Dec 31, 2021

breezewish commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

zhouqiang-cl commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

sre-bot commented Dec 31, 2021 •

edited

Loading

crazycs520 commented Dec 31, 2021

zhouqiang-cl commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

topsql: make topsql enable only be controlled by pub/sub sink #31209

topsql: make topsql enable only be controlled by pub/sub sink #31209

Conversation

crazycs520 commented Dec 31, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 31, 2021 • edited Loading

ti-chi-bot commented Dec 31, 2021

breezewish left a comment

Choose a reason for hiding this comment

breezewish commented Dec 31, 2021 • edited Loading

crazycs520 commented Dec 31, 2021

bb7133 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

zhouqiang-cl commented Dec 31, 2021

breezewish commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

zhouqiang-cl commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

sre-bot commented Dec 31, 2021 • edited Loading

crazycs520 commented Dec 31, 2021

zhouqiang-cl commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021

crazycs520 commented Dec 31, 2021

ti-chi-bot commented Dec 31, 2021 •

edited

Loading

breezewish commented Dec 31, 2021 •

edited

Loading

sre-bot commented Dec 31, 2021 •

edited

Loading