Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix topn wrongly pushed to index scan side when it's a prefix index #29778

Merged
merged 8 commits into from
Nov 15, 2021
Merged

planner: fix topn wrongly pushed to index scan side when it's a prefix index #29778

merged 8 commits into from
Nov 15, 2021

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #29711

Problem Summary:

When the IndexScan is using a prefix index, and the TopN.ByItems used the prefix column, the TopN is wrongly pushed to indexPlan.

What is changed and how it works?

Check and push TopN to tablePlan in the above case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2021
@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-5.3
/label needs-cherry-pick-5.2
/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0

xuyifangreeneyes
xuyifangreeneyes approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021
@time-and-fate
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 55cc160

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@ti-chi-bot ti-chi-bot merged commit a0d3f4f into pingcap:master Nov 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 15, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#29778 to release-4.0
0fd9d4f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 15, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #29796

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 15, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#29778 to release-5.0
35fe25e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 15, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #29797

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 15, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#29778 to release-5.1
04e1fd6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 15, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #29798

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 15, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#29778 to release-5.2
1ff47b7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 15, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #29799

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 15, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#29778 to release-5.3
5f11522 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 15, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #29800

ti-chi-bot pushed a commit that referenced this pull request Nov 15, 2021
@ti-srebot
planner: fix topn wrongly pushed to index scan side when it's a prefi…
70cbb55 
…x index (#29778) (#29800)
ti-chi-bot pushed a commit that referenced this pull request Nov 22, 2021
@ti-srebot
planner: fix topn wrongly pushed to index scan side when it's a prefi…
1e156bc 
…x index (#29778) (#29796)
ti-chi-bot pushed a commit that referenced this pull request Dec 17, 2021
@ti-srebot
planner: fix topn wrongly pushed to index scan side when it's a prefi…
a004bee 
…x index (#29778) (#29797)
ti-chi-bot pushed a commit that referenced this pull request Feb 7, 2022
@ti-srebot
planner: fix topn wrongly pushed to index scan side when it's a prefi…
bf823e1 
…x index (#29778) (#29798)

close #29711
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2022
@ti-srebot
planner: fix topn wrongly pushed to index scan side when it's a prefi…
081e449 
…x index (#29778) (#29799)

close #29711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

order by + limit + utf8_unicode_ci，return error record
5 participants
@time-and-fate @ti-chi-bot @ti-srebot @winoros @xuyifangreeneyes