-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types/datum.go: casting zero to enum should not change value #29759
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ca36487
types/datum.go: cast 0 to enum should not change value
tangenta 6ffce94
types: address comment
tangenta b47e94e
Merge branch 'master' into enum-fix
AilinKid 62ceee2
types: add a comment
tangenta 2c0447d
types: clarify MySQL enum zero value in comment
tangenta 8a9897e
fix other enum zero value corner case
tangenta 80d753a
fix integration test
tangenta 8e8b6bc
Merge branch 'master' into enum-fix
ti-chi-bot 29c4ac6
Merge branch 'master' into enum-fix
ti-chi-bot cb04b36
Merge branch 'master' into enum-fix
ti-chi-bot 8c9bca3
Merge branch 'master' into enum-fix
ti-chi-bot 80b892d
fix integration test TestIssue19229
tangenta dcca576
make fmt
tangenta ae23f3e
Merge branch 'master' into enum-fix
tangenta 425df5d
Merge branch 'master' into enum-fix
ti-chi-bot 7a4c56f
Merge branch 'master' into enum-fix
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can change
enum('a', '')
toenum('a', 'b')
, mysql can do it without any warnings or any error under default sql_modeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only
enum('a', '')
can reproduce the problem. If I change it toenum('a', 'b')
, the value is still0
.