-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support plan replayer load #29247
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
executor/builder.go
Outdated
baseExecutor: newBaseExecutor(b.ctx, nil, v.ID()), | ||
info: &PlanReplayerLoadInfo{Path: v.File, Ctx: b.ctx}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why hold b.ctx twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PlanReplayerLoadInfo
will use Ctx
when alone. You can see handlePlanReplayerLoad
for details.
executor/plan_replayer.go
Outdated
return errors.New("plan replayer: create schema and tables failed") | ||
} | ||
// create database | ||
_, err = ctx.(sqlexec.SQLExecutor).Execute(context.TODO(), sqls[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use sessioncontext's ctx instead of context.TODO()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the meanings of the two are different. Refer to other usage methods, I think it is more appropriate to use context.Background()
. Updated.
Co-authored-by: Song Gao <disxiaofei@163.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a53897a
|
@rebelice: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev_2 |
What problem does this PR solve?
Issue Number: close #29246
Problem Summary:
support plan replayer load
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note