-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: Fix bug that mpp node availability detect does not work in some corner cases (#28201) #28288
copr: Fix bug that mpp node availability detect does not work in some corner cases (#28201) #28288
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f1962c4
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #28201 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/28288
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close pingcap/tiflash#3118
Problem Summary:
As described in the issue.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is we detect the TiFlash node's availability in
balanceBatchCopTask
, but here is a shortcut inbalanceBatchCopTask
that if there is only one batchCopTask, it will return directly without balancing, which means the availability check is also skipped.tidb/store/copr/batch_coprocessor.go
Lines 107 to 111 in 3c9c01e
This pr fix this by not trigger the shortcut if the query is mpp query.
Check List
Tests
Side effects
Documentation
Release note