Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br,test: fix data race for parquet test #27482

Merged
merged 8 commits into from
Aug 23, 2021
Merged

br,test: fix data race for parquet test #27482

merged 8 commits into from
Aug 23, 2021

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Aug 23, 2021

What problem does this PR solve?

Issue Number: close #27473

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test

Side effects

Documentation

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • Little-Wallace

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Aug 23, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/label needs-cherry-pick-release-5.2

@ti-chi-bot
Copy link
Member

@glorv: The label(s) needs-cherry-pick-release-5.2 cannot be applied. These labels are supported: CHANGELOG, challenge-program, compatibility-breaker, contribution, correctness, first-time-contributor, good-first-issue, hacktoberfest, high-performance, hptc, need-more-info, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, needs-cherry-pick-5.2, proposal, release-note, require-LGT3, security, tools.

In response to this:

/label needs-cherry-pick-release-5.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021 •
edited
Loading

/label needs-cherry-pick-5.2

@tisonkun
Copy link
Contributor

@glorv IIUC SerialSuite means only all SerialSuite run in serial, but it is still run parallel with other Suite. How does this PR fix the problem?

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

parallel

No. SerialSuites are scheduled to be running serially at last. So there should be no data race then

@tisonkun
Copy link
Contributor

@glorv thanks for your explanation! Good to know and checked it.

Little-Wallace
Little-Wallace approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 23, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 23, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 681b9ce

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 23, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 410220e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 23, 2021
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/rebuild

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run_unit-test

4 similar comments
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run_unit-test

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run_unit-test

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run_unit-test

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run_unit-test

@zhouqiang-cl
Copy link
Contributor

/run-unit-tests

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-unit-test

1 similar comment
@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-unit-test

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-check_dev_2

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-check_dev_2

2 similar comments
@tisonkun
Copy link
Contributor

/run-check_dev_2

@glorv
Copy link
Contributor Author

glorv commented Aug 23, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 3731229 into pingcap:master Aug 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 23, 2021
@glorv @ti-srebot
cherry pick pingcap#27482 to release-5.2
3c4ce3d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 23, 2021
Merged
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27516

ti-chi-bot pushed a commit that referenced this pull request Aug 23, 2021
@ti-srebot
br,test: fix data race for parquet test (#27482) (#27516)
8ceb258
@glorv glorv deleted the fix-test branch August 23, 2021 15:16
joccau pushed a commit to joccau/tidb that referenced this pull request Sep 7, 2021
@glorv
br,test: fix data race for parquet test (pingcap#27482)
7ddc086
@kennytm kennytm mentioned this pull request Sep 13, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@3pointer 3pointer 3pointer approved these changes

@Little-Wallace Little-Wallace Little-Wallace approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race in br/pkg/lightning/mydump.setDatumByInt()
8 participants
@glorv @ti-chi-bot @tisonkun @zhouqiang-cl @ti-srebot @kennytm @3pointer @Little-Wallace