Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br:backup: If make a backup of empty db, should get a success summary #27467

Merged
merged 9 commits into from
Aug 24, 2021
Merged

br:backup: If make a backup of empty db, should get a success summary #27467

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c327b3
If make a backup of empty db, should get a success summary
joccau Aug 21, 2021
38ff83d
Merge branch 'master' into fix-backup-emptydb
joccau Aug 23, 2021
c83ec9d
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 23, 2021
41eb63f
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 24, 2021
f01eb1f
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 24, 2021
3e55b30
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 24, 2021
05336d7
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 24, 2021
52667be
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 24, 2021
18540b8
Merge branch 'master' into fix-backup-emptydb
ti-chi-bot Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion br/pkg/task/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,12 @@ func RunBackup(c context.Context, g glue.Glue, cmdName string, cfg *BackupConfig
pdAddress := strings.Join(cfg.PD, ",")
log.Warn("Nothing to backup, maybe connected to cluster for restoring",
zap.String("PD address", pdAddress))
return metawriter.FlushBackupMeta(ctx)

err = metawriter.FlushBackupMeta(ctx)
if err == nil {
summary.SetSuccessStatus(true)
}
return err
}

if isIncrementalBackup {
Expand Down