Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: migrate leak tests to goleak #27433

Merged
merged 17 commits into from
Aug 24, 2021
Merged

planner/core: migrate leak tests to goleak #27433

merged 17 commits into from
Aug 24, 2021

Conversation

tisonkun
Copy link
Contributor

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #27432

Release note

None

@tisonkun
planner/core: migrate leak tests to goleak
49007ba 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 20, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2021
@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

/cc @Reminiscent @qw4990

@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun tisonkun marked this pull request as draft August 21, 2021 01:17
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2021
@tisonkun
fix leak
6fb1a5c 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun tisonkun marked this pull request as ready for review August 21, 2021 02:27
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2021
@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@tisonkun
Copy link
Contributor Author

/cc @Reminiscent @qw4990

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 24, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 997c3f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@tisonkun
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@tisonkun: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tisonkun
Copy link
Contributor Author

/run-all-tests

@tisonkun
Copy link
Contributor Author

/run-check_dev_2

@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6849e5d into pingcap:master Aug 24, 2021
@tisonkun tisonkun deleted the issue-27432 branch March 4, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate leak tests to goleak for planner/core
4 participants
@tisonkun @ti-chi-bot @Reminiscent @qw4990