-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: explicitly set analyze sample number if tidb_analyze_version = 2 #27402
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/component lightning |
/run-check_dev |
release-5.2? is this a cherry-pick of some PR not listed, or #27391 does not affect master? |
/run-check_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// TODO: because tidb v5.2 analyze full table OOM easily, we fallback to add `WITH NUM 10000` parameter | ||
// if there are more than 600 regions in this table | ||
sql := "ANALYZE TABLE "+tr.tableName | ||
result, err := g.QueryStringsWithLog(ctx, "SHOW VARIABLES LIKE 'tidb_analyze_version'", "fetch tidb analyze version", tr.logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just select @@tidb_analyze_version
😕 (fallback to 1 on error)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally want to be compatible with v4.0, but It's simplier to fallback to 1 on error.
/run-check_dev |
4 similar comments
/run-check_dev |
/run-check_dev |
/run-check_dev |
/run-check_dev |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 45d454a
|
@glorv: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #27391
Problem Summary: Analyze table OOM easily when
tidb_analyze_version = 2
What is changed and how it works?
Add explicitly analyze parameter
WITH NUM 10000
if the TiDB'stidb_analyze_version = 2
and there are more than 600 regions in target table.Check List
Tests
analyze table
andanalyze table with 10000 samples
results in the same result(withtidb_build_stats_concurrency = 20;
which the default lightning config).Side effects
Documentation
Release note