Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the problem of using enum like 'x%' to build the wrong range #27267

Merged
merged 5 commits into from
Aug 17, 2021
Merged

planner: fix the problem of using enum like 'x%' to build the wrong range #27267

merged 5 commits into from
Aug 17, 2021

Conversation

rebelice
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27130

Problem Summary:

We used enum like 'x%' to build the wrong range. In fact, we do not support the use of enum like 'x%' as access condition of IndexReader.

What is changed and how it works?

Let enum like 'x%' be filter condition of IndexReader.

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

planner: fix the problem of using `enum like 'x%'` to build the wrong range

@rebelice rebelice added the sig/planner SIG: Planner label Aug 16, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
@ichn-hu ichn-hu mentioned this pull request Aug 16, 2021
Closed
@rebelice
Copy link
Contributor Author

/run-check_dev_2

@qw4990 qw4990 added the type/bugfix This PR fixes a bug. label Aug 17, 2021
@qw4990 qw4990 requested review from winoros and qw4990 August 17, 2021 02:03
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2021
Reminiscent
Reminiscent reviewed Aug 17, 2021
View reviewed changes
util/ranger/checker.go
// see https://github.com/pingcap/tidb/issues/27130 for more details
if scalar.GetArgs()[0].GetType().Tp == mysql.TypeEnum {
return false
}
if i != len(patternStr)-1 {
c.shouldReserve = true
}
break
}
if patternStr[i] == '_' {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for this case. Rest LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2021
@winoros
Copy link
Member

winoros commented Aug 17, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 40fe7f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2021
@ti-chi-bot ti-chi-bot merged commit 4d5350c into pingcap:master Aug 17, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 17, 2021
@rebelice @ti-srebot
cherry pick pingcap#27267 to release-5.2
dbe63aa 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 17, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27289

ti-chi-bot pushed a commit that referenced this pull request Aug 17, 2021
@ti-srebot
planner: fix the problem of using enum like 'x%' to build the wrong…
e779c8a 
… range (#27267) (#27289)
@qw4990
Copy link
Contributor

qw4990 commented Sep 7, 2021

/cherry-pick release-5.1

@qw4990
Copy link
Contributor

qw4990 commented Sep 15, 2021

/cherry-pick release-5.1

@rebelice
Copy link
Contributor Author

/cherry-pick

@rebelice
Copy link
Contributor Author

/cherrypick release-5.1

rebelice added a commit to rebelice/tidb that referenced this pull request Sep 15, 2021
@rebelice
planner: fix the problem of using enum like 'x%' to build the wrong…
db2edfb 
… range (pingcap#27267)
@rebelice rebelice mentioned this pull request Sep 15, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@winoros winoros winoros approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of query using the tabledual plan is not correct
6 participants
@rebelice @ti-chi-bot @winoros @ti-srebot @qw4990 @Reminiscent