Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix expression rewrite makes between expr infers wrong collation. #27254

Merged
merged 6 commits into from
Aug 24, 2021
Merged

planner: fix expression rewrite makes between expr infers wrong collation. #27254

merged 6 commits into from
Aug 24, 2021

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27146

a between b and c expression will be rewritten to a>=b and a<=c, which makes infer wrong collation, the collation of between expression should be inferred as a whole.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

fix expression rewrite makes between expr infers wrong collation.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
wjhuang2016
wjhuang2016 reviewed Aug 16, 2021
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI

@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei xiongjiwei requested review from XuHuaiyu, eurekaka and a team August 17, 2021 02:03
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@xiongjiwei
Copy link
Contributor Author

/run-check_dev_2

@xiongjiwei xiongjiwei requested a review from xhebox August 24, 2021 02:30
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 24, 2021
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c7a8f89

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 24, 2021
@bb7133
Copy link
Member

bb7133 commented Aug 24, 2021

/merge

@bb7133
Copy link
Member

bb7133 commented Aug 24, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit d5baa5d into pingcap:master Aug 24, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27254 to release-5.0
c75d9c8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #27548

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27254 to release-5.1
b52d315 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #27549

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 24, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27254 to release-5.2
c129701 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #27550

ti-chi-bot pushed a commit that referenced this pull request Sep 3, 2021
@ti-srebot
planner: fix expression rewrite makes between expr infers wrong colla…
814d442 
…tion. (#27254) (#27548)
@LittleFall LittleFall mentioned this pull request Sep 6, 2021
Closed
@xiongjiwei
Copy link
Contributor Author

/cherry-pick

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#27254 to release-4.0
f58604a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #27851

ti-chi-bot pushed a commit that referenced this pull request Sep 10, 2021
@ti-srebot
planner: fix expression rewrite makes between expr infers wrong colla…
2efc9c4 
…tion. (#27254) (#27851)
ti-chi-bot pushed a commit that referenced this pull request Sep 15, 2021
@ti-srebot
planner: fix expression rewrite makes between expr infers wrong colla…
92a3f0a 
…tion. (#27254) (#27549)
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
ti-chi-bot pushed a commit that referenced this pull request Oct 14, 2021
@ti-srebot
planner: fix expression rewrite makes between expr infers wrong colla…
f229d16 
…tion. (#27254) (#27550)
@zhangjinpeng87 zhangjinpeng87 mentioned this pull request Oct 14, 2021
Closed
12 tasks
@xiongjiwei xiongjiwei deleted the between-expr-infer-collation branch September 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@AilinKid AilinKid AilinKid approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@eurekaka eurekaka Awaiting requested review from eurekaka

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of association sub query is not correct
6 participants
@xiongjiwei @ti-chi-bot @bb7133 @ti-srebot @AilinKid @wjhuang2016