Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add temp_table_size support for local temporary table #27205

Merged
merged 10 commits into from
Aug 16, 2021
Merged

*: Add temp_table_size support for local temporary table #27205

merged 10 commits into from
Aug 16, 2021

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Aug 13, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #25928

Add temp_table_size support for local temporary table. temp_table_size should also limit the committed data in session.

What is changed and how it works?

Create a new interface variable.TemporaryTableData to mange temporary table data. SetTableKey and DeleteTableKey will recompute size of table atomically

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 13, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2021
@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Aug 13, 2021
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@github-actions github-actions bot added the sig/execution SIG execution label Aug 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
djshow832
djshow832 approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern: When a session has 800M data in the session data, and the user deletes all of the data in a new transaction, then it reports memory full because the deleted data occupies the transaction data.
It looks weird to users. However, I have no better ideas...

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 298fc93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@lcwangchao
Copy link
Collaborator Author

/rebuild

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@lcwangchao
Copy link
Collaborator Author

/run-all-tests

@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 462c9dc into pingcap:master Aug 16, 2021
@lcwangchao lcwangchao deleted the fix_25928 branch August 16, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory size does not exceed temp_table_size
4 participants
@lcwangchao @ti-chi-bot @djshow832 @tiancaiamao