-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix the unstable test TestOrderedResultModeOnOtherOperators (#26481) #26492
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@qw4990 you're already a collaborator in bot's repo. |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/rebuild |
�It seems the bot check conflicting files wrongly, I'll close this and submit another pick PR later. |
I found this PR has already been picked by #23373 |
cherry-pick #26481 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26492
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #26376
Problem Summary: planner: fix the unstable test TestOrderedResultModeOnOtherOperators
What is changed and how it works?
This query has two window-spec fields that both are partitioned by
a
, but now the optimizer cannot sort them stably in this case:To fix this unstable test quickly, I remove one field.
Check List
Tests
Release note
No release note