Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: access the table_storage_stats need privilege #26298

Merged
merged 12 commits into from
Jul 19, 2021
Merged

exec: access the table_storage_stats need privilege #26298

merged 12 commits into from
Jul 19, 2021

Conversation

AilinKid
Copy link
Contributor

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #26128

What is changed and how it works?

*: What's Changed: add the super privilege control for access table_storage_stats

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

  • exec: access the table_storage_stats need super privilege

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 16, 2021
@AilinKid
change process to super
5fbbdd1 
Signed-off-by: ailinkid <314806019@qq.com>
djshow832
djshow832 reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user should be able to access the tables to which he has privileges.

@github-actions github-actions bot added the sig/execution SIG execution label Jul 16, 2021
@AilinKid
add the privilege check
8004a9a 
Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2021
@AilinKid
Copy link
Contributor Author

The user should be able to access the tables to which he has privileges.

done

@AilinKid AilinKid changed the title exec: access the table_storage_stats need super privilege exec: access the table_storage_stats need allPriv privilege Jul 19, 2021
@AilinKid
address comment
8d0dcdc 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
address comment
a17fe78 
Signed-off-by: ailinkid <314806019@qq.com>
@AilinKid
Merge branch 'master' into fix-table-storage-stats
60ec9c6
zimulala
zimulala approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 19, 2021
@crazycs520 crazycs520 changed the title exec: access the table_storage_stats need allPriv privilege exec: access the table_storage_stats need privilege Jul 19, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 60ec9c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2021
@ti-chi-bot ti-chi-bot merged commit 9833e64 into pingcap:master Jul 19, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 19, 2021
@AilinKid @ti-srebot
cherry pick pingcap#26298 to release-5.1
9556100 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 19, 2021
Merged
3 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26352

ti-chi-bot pushed a commit that referenced this pull request Jul 19, 2021
@ti-srebot
exec: access the table_storage_stats need privilege (#26298) (#26352)
09bba1a
@djshow832 djshow832 mentioned this pull request Jul 20, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@zimulala zimulala zimulala approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users without super privilege should be unable to query TABLE_STORAGE_STATS of other users
6 participants
@AilinKid @ti-chi-bot @djshow832 @ti-srebot @zimulala @crazycs520