*: reduce ResetContextOfStmt() object allocation #26241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/M
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
tiancaiamao
commented
Jul 14, 2021
| @@ -543,7 +543,6 @@ func (s *testTableSuite) TestSomeTables(c *C) { | |||
| Command: byte(1), | |||
| Digest: "abc1", | |||
| State: 1, | |||
| StmtCtx: tk.Se.GetSessionVars().StmtCtx, | |||
There was a problem hiding this comment.
Take out tk.Se.GetSessionVars().StmtCtx for future use is not correct, it's not a snapshot.
The correct usage should be Lock -> Read data -> Unlock for process info ...
See #26196
tiancaiamao
commented
Jul 14, 2021
| @@ -2169,7 +2169,6 @@ func (s *testSuite4) TestLoadData(c *C) { | |||
| {[]byte("\t2\t3"), []byte("\t4\t5"), nil, []byte("\t2\t3\t4\t5"), "Records: 0 Deleted: 0 Skipped: 0 Warnings: 0"}, | |||
| } | |||
| checkCases(tests, ld, c, tk, ctx, selectSQL, deleteSQL) | |||
| c.Assert(sc.WarningCount(), Equals, uint16(1)) | |||
There was a problem hiding this comment.
This check is incorrect. The warnings is reset after the next statement.
The correct behavior should be check warning immediately after a statement.
The old code rely on every time a new statement context is allocated ... so even it does not checked immediately, the data is not overwritten.
github-actions
bot
added
sig/execution
xhebox
approved these changes
Jul 20, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tangenta
approved these changes
Aug 3, 2021
ti-chi-bot
added
status/LGT2
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
/merge cancel DATA RACE detected |
ti-chi-bot
removed
the
status/can-merge
12 tasks
|
After #26909 the DATA RACE should be OK |
ti-chi-bot
added
the
needs-rebase
ti-chi-bot
removed
the
needs-rebase
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
/run-unit-test |
|
This seems to be a unstable test on the master branch but it seems to become reproducable in this branch. |
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge cancel |
ti-chi-bot
removed
the
status/can-merge
|
Wait for this one #26538 to be fixed. |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e3fbf8f
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Reduce object allocation for #25573
Problem Summary:
What is changed and how it works?
What's Changed:
The tests are modified because they are incorrect.
How it Works:
Use two statement context add switch between them, so the allocation of
StatementContextis almost eliminated.Check List
Tests
Allocate size per op drop from 7054 to 5902 ... it means the speed of garbage generation is slower
Side effects
Documentation
Release note