Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix user without process privilege can access cluster's systemInfo, Load, Hardware #26211

Closed
wants to merge 2 commits into from

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jul 13, 2021

Signed-off-by: ailinkid 314806019@qq.com

What problem does this PR solve?

Issue Number: close #26121, #26123, #26126

What is changed and how it works?

*: What's Changed: executor: fix user without process privilege can access cluster's systemInfo, Load, Hardware

Check List

Tests

  • Unit test
  • Integration test

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

  • executor: fix user without process privilege can access cluster's systemInfo, Load, Hardware

…oad, Hardware

Signed-off-by: ailinkid <314806019@qq.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 13, 2021
@mjonss
Copy link
Contributor

mjonss commented Jul 13, 2021

I did something similar in #26220 please take a look which of the similar patches we should use 😄
Otherwise LGTM

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (at least manually) that users with process privilege can access those tables.

@AilinKid
Copy link
Contributor Author

Duplicated with #26220, we will use it.

@AilinKid AilinKid closed this Jul 14, 2021
@AilinKid AilinKid reopened this Jul 14, 2021
@AilinKid
Copy link
Contributor Author

AilinKid commented Jul 14, 2021

I found these tests can be suppliments to #26220, so after it merged, I will merge these tests.

@AilinKid AilinKid closed this Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users without process privilege should be unable to query cluster_hardware
4 participants