Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Keep view always select non-local-temporary table #26087

Merged
merged 5 commits into from
Jul 13, 2021
Merged

planner: Keep view always select non-local-temporary table #26087

merged 5 commits into from
Jul 13, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #25917

Problem Summary:

What is changed and how it works?

When buildDataSource, check builder.buildingViewStack in build to determine wether building view or not. If it is true and infoschema is TemporaryTableAttachedInfoSchema, replace it with a underlying one.

Related changes

  • N/A

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2021
@lcwangchao lcwangchao mentioned this pull request Jul 9, 2021
Closed
89 tasks
djshow832
djshow832 reviewed Jul 12, 2021
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

planner/core/logical_plan_builder.go Outdated
is := b.is
if len(b.buildingViewStack) > 0 {
if tempIs, ok := is.(*infoschema.TemporaryTableAttachedInfoSchema); ok {
// for tables in view, always ignore local temporary table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please give an example or describe it in more detail here. Others may be confused as I am: why do you need to check again in SELECT.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2021
@lcwangchao @djshow832
Update planner/core/logical_plan_builder.go
36b10ad 
fix

Co-authored-by: djshow832 <zhangming@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 13, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 36b10ad

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2021
@ti-chi-bot
Copy link
Member

@lcwangchao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 276a669 into pingcap:master Jul 13, 2021
@lcwangchao lcwangchao deleted the select_view_ignore_tmp_table branch July 14, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View should always read non local temporary table
5 participants
@lcwangchao @sre-bot @ti-chi-bot @djshow832 @tiancaiamao