Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix index-out-of-range error when checking only_full_group_by and make sure limit outputs no more columns than its child #25693

Closed
wants to merge 1 commit into from
Closed

planner: fix index-out-of-range error when checking only_full_group_by and make sure limit outputs no more columns than its child #25693

wants to merge 1 commit into from

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

hotfix based on v5.0.2

composed of #24016 and #25516

What is changed and how it works?

  1. fix index-out-of-range error when checking only_full_group_by
  2. make sure limit outputs no more columns than its child

Related changes

None

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix index-out-of-range error when checking only_full_group_by && make sure limit outputs no more columns than its child

@xuyifangreeneyes
planner: fix index-out-of-range error when checking only_full_group_b…
c77aeba 
…y && make sure limit outputs no more columns than its child
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xuyifangreeneyes xuyifangreeneyes requested a review from a team as a code owner June 23, 2021 03:26
@xuyifangreeneyes xuyifangreeneyes requested review from qw4990 and removed request for a team June 23, 2021 03:26
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Jun 23, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@xuyifangreeneyes
Copy link
Contributor Author

@zhouqiang-cl

@xuyifangreeneyes xuyifangreeneyes changed the title planner:fix index-out-of-range error when checking only_full_group_by && make sure limit outputs no more columns than its child planner: fix index-out-of-range error when checking only_full_group_by && make sure limit outputs no more columns than its child Jun 23, 2021
@xuyifangreeneyes xuyifangreeneyes changed the title planner: fix index-out-of-range error when checking only_full_group_by && make sure limit outputs no more columns than its child planner: fix index-out-of-range error when checking only_full_group_by and make sure limit outputs no more columns than its child Jun 23, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2021
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xuyifangreeneyes xuyifangreeneyes deleted the hotfix_5.0.2 branch October 30, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
do-not-merge/cherry-pick-not-approved needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuyifangreeneyes @ti-chi-bot @sre-bot