expression: fix IN expr critical bug (#25653)

[ti-srebot]

cherry-pick #25653 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25666

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25666:release-5.0-ea1a1e79c5f4

---

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #25591

Problem Summary: The implementation of IN expr will change its arguments array unexpectedly. For example:

t1.c1 IN (1, t2.c1, t2.c2);
original args: (t1.c1, 1, t2.c1, t2.c2)
after: (t1.c1, t2.c1, t2.c2, t2.c2)

What is changed and how it works?

What's Changed: If we need to change local args slice, make a new underlying array instead of changing the expr's(b.args should not be changed)

Related changes

• PR to update pingcap/docs/pingcap/docs-cn:
• Need to cherry-pick to the release branch

Check List

Tests

• Integration test

Side effects: May use extra memory to store local arguments array.

Release note

• expression: fix IN expr critical bug

[ti-srebot]

/run-all-tests

[ti-srebot]

@guo-shaoge you're already a collaborator in bot's repo.

[XuHuaiyu]

LGTM

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• XuHuaiyu
• wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[zhouqiang-cl]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: d55d071

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.