Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: stable tests #25495

Merged
merged 3 commits into from
Jun 16, 2021
Merged

executor: stable tests #25495

merged 3 commits into from
Jun 16, 2021

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Jun 16, 2021

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Problem Summary: Reported by @tiancaiamao . Need a sleep to wait for table creation, otherwise stale reads may read the old table in the unistore on disks, using the new infoschema, on some really fast computers.

This PR is tested more than 1000 runs on my laptop. It should be stable enough now.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from a team as a code owner June 16, 2021 11:48
@xhebox xhebox requested review from wshwsh12 and removed request for a team June 16, 2021 11:48
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2021
@xhebox xhebox removed the request for review from wshwsh12 June 16, 2021 11:48
@github-actions github-actions bot added the sig/execution SIG execution label Jun 16, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2021
@nolouch nolouch removed the sig/execution SIG execution label Jun 16, 2021
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2021
@nolouch
Copy link
Member

nolouch commented Jun 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b3d7b0e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 16, 2021
@ti-chi-bot
Copy link
Member

@xhebox: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b43f24f into pingcap:master Jun 16, 2021
@xhebox xhebox deleted the stale_9 branch September 28, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants