planner: make sure limit outputs no more columns than its child #25345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/S
winoros
approved these changes
Jun 10, 2021
Closed
lzmhhh123
approved these changes
Jun 15, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: b108b40
|
ti-chi-bot
added
the
status/can-merge
|
cherry pick to release-5.0 in PR #25517 |
eurekaka
added a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 17, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-chi-bot
pushed a commit
that referenced
this pull request
Jun 21, 2021
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 6, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.1 in PR #25980 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #25344
Problem Summary:
panic may happen when limit is on top of window functions
What is changed and how it works?
What's Changed:
Prune columns for child operator first, and then re-assign schema for limit.
How it Works:
Make sure limit outputs no more columns than its child
Related changes
N/A
Check List
Tests
Side effects
N/A
Release note