Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sli: move small read duration metrics to store/tikv #25343

Merged
merged 2 commits into from
Jun 11, 2021
Merged

sli: move small read duration metrics to store/tikv #25343

merged 2 commits into from
Jun 11, 2021

Conversation

disksing
Copy link
Contributor

Signed-off-by: disksing i@disksing.com

What problem does this PR solve?

Found new PR introduces dependency and prevents us to move store/tikv to standalone repo.

Part of #22513

What is changed and how it works?

What's Changed:

  • move metrics to store/tikv/metrics

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing
sli: move small read duration metrics to store/tikv
9ec1ac1 
Signed-off-by: disksing <i@disksing.com>
@disksing disksing requested a review from a team as a code owner June 10, 2021 12:17
@disksing disksing requested review from XuHuaiyu and removed request for a team June 10, 2021 12:17
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 10, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 10, 2021
@jyz0309 jyz0309 requested a review from crazycs520 June 10, 2021 13:46
AndreMouche
AndreMouche approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@sticnarf
Copy link
Contributor

cc @crazycs520

@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 11, 2021 03:16
crazycs520
crazycs520 approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 11, 2021
@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6ffa33d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@disksing
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 9505b4b into pingcap:master Jun 11, 2021
@disksing disksing deleted the sli branch June 11, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@jyz0309 jyz0309 Awaiting requested review from jyz0309

Assignees
No one assigned
Labels
sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@disksing @sticnarf @ti-chi-bot @crazycs520 @AndreMouche