Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support push function replace down to TiFlash #25084

Merged
merged 14 commits into from
Jun 4, 2021
Merged

expression: Support push function replace down to TiFlash #25084

merged 14 commits into from
Jun 4, 2021

Conversation

fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Jun 3, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: pingcap/tiflash#1860

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Support push down function replace to TiFlash.

@fuzhe1989 fuzhe1989 requested a review from a team as a code owner June 3, 2021 06:10
@fuzhe1989 fuzhe1989 requested review from XuHuaiyu and removed request for a team June 3, 2021 06:10
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@fuzhe1989
Copy link
Contributor Author

/cc @zanmato1984

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2021
zanmato1984
zanmato1984 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
jackysp
jackysp approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@jackysp
Copy link
Member

jackysp commented Jun 3, 2021

Please add the release note and resolve conflicts. @fuzhe1989

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

1 similar comment
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fuzhe1989
Copy link
Contributor Author

/run-common-test

@fuzhe1989
Copy link
Contributor Author

/run-e2e-test

@fuzhe1989
Copy link
Contributor Author

/run-integration-common-test

@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zanmato1984
Copy link
Contributor

/merge

@zanmato1984
Copy link
Contributor

/merge

1 similar comment
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit 9a1e57c into pingcap:master Jun 4, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 4, 2021
@fuzhe1989 @ti-srebot
cherry pick pingcap#25084 to release-5.0
b46e3fc 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25171

@fuzhe1989 fuzhe1989 mentioned this pull request Jun 18, 2021
Merged
@fuzhe1989 fuzhe1989 deleted the fuzhe/push_replace_down_to_tiflash branch August 3, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@jackysp jackysp jackysp approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fuzhe1989 @ti-srebot @ti-chi-bot @jackysp @fzhedu @zanmato1984