Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support push function unix_timestamp, concat down to TiFlash. #25083

Merged
merged 3 commits into from
Jun 3, 2021
Merged

expression: Support push function unix_timestamp, concat down to TiFlash. #25083

merged 3 commits into from
Jun 3, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jun 3, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: pingcap/tiflash#1940, pingcap/tiflash#1939

Problem Summary:

Function: push unix_timestamp, concat to TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: no need

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Support push function unix_timestamp, concat down to TiFlash.

@LittleFall LittleFall requested a review from a team as a code owner June 3, 2021 05:54
@LittleFall LittleFall requested review from lzmhhh123 and removed request for a team June 3, 2021 05:54
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

1 similar comment
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@LittleFall
Copy link
Contributor Author

/run-check_release_note

@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/run-e2e-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@LittleFall LittleFall force-pushed the cherrypick/unix_timestamp,concat branch from c55317d to 7d0aa8b Compare June 3, 2021 06:49
@LittleFall
Copy link
Contributor Author

/run-all-tests

windtalker
windtalker approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanfei1991
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7d0aa8b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/run-e2e-test

@LittleFall
Copy link
Contributor Author

/run-unit-test

@LittleFall
Copy link
Contributor Author

/run-check_dev_2

@LittleFall
Copy link
Contributor Author 

[2021-06-03T07:00:27.644Z] 
[2021-06-03T07:00:27.644Z] ----------------------------------------------------------------------
[2021-06-03T07:00:27.644Z] FAIL: handle_test.go:909: testStatsSuite.TestAnalyzeGlobalStatsWithOpts2
[2021-06-03T07:00:27.644Z] 
[2021-06-03T07:00:27.644Z] handle_test.go:917:
[2021-06-03T07:00:27.644Z]     s.checkForGlobalStatsWithOpts(c, tk, "p1", 1, 50)
[2021-06-03T07:00:27.644Z] handle_test.go:869:
[2021-06-03T07:00:27.644Z]     // since the hist-building algorithm doesn't stipulate the final bucket number to be equal to the expected number exactly,
[2021-06-03T07:00:27.644Z]     // we have to check the results by a range here.
[2021-06-03T07:00:27.644Z]     c.Assert(numBuckets >= buckets-delta, IsTrue)
[2021-06-03T07:00:27.645Z] ... obtained bool = false
[2021-06-03T07:00:27.645Z]

@ti-chi-bot ti-chi-bot merged commit 6a1ebeb into pingcap:master Jun 3, 2021
@LittleFall LittleFall deleted the cherrypick/unix_timestamp,concat branch June 3, 2021 07:12
@LittleFall LittleFall changed the title expression: Support push fucntion unix_timestamp, concat down to TiFlash. expression: Support push function unix_timestamp, concat down to TiFlash. Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/label needs-cherry-pick-5.0

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 4, 2021
@LittleFall @ti-srebot
cherry pick pingcap#25083 to release-5.0
909ecb5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25146

LittleFall added a commit to LittleFall/tidb that referenced this pull request Jun 18, 2021
@LittleFall
expression: Support push fucntion unix_timestamp, concat down to TiFl…
5c873e7 
…ash. (pingcap#25083)
@LittleFall LittleFall mentioned this pull request Jun 18, 2021
Merged
@LittleFall LittleFall mentioned this pull request Jul 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LittleFall @ti-srebot @ti-chi-bot @windtalker @hanfei1991