Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session, planner: Add a factor getter for networkFactor/scanFactor/descScanFactor/seekFactor #25046

Merged
merged 24 commits into from
Jun 3, 2021

Conversation

mmyj
Copy link
Member

@mmyj mmyj commented Jun 2, 2021

What problem does this PR solve?

Problem Summary:

Add the factor getter for networkFactor/scanFactor/descScanFactor/seekFactor. The getter will return 0, when the data source table is a temporary table.

What is changed and how it works?

How it Works:

The getter will return 0, when the model.TableInfo is a temporary table.

Related changes

  • N/A

Check List

Tests

  • No code

Side effects

  • N/A

Release note

  • Add a factor getter for networkFactor/scanFactor/descScanFactor/seekFactor

@mmyj mmyj requested a review from a team as a code owner June 2, 2021 03:33
@mmyj mmyj requested review from qw4990 and removed request for a team June 2, 2021 03:33
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2021
@djshow832 djshow832 added sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra labels Jun 2, 2021
@djshow832 djshow832 mentioned this pull request Jun 2, 2021
89 tasks
planner/core/task.go Outdated Show resolved Hide resolved
planner/implementation/datasource.go Show resolved Hide resolved
planner/core/task.go Outdated Show resolved Hide resolved
@mmyj mmyj requested a review from djshow832 June 2, 2021 12:58
planner/core/task.go Outdated Show resolved Hide resolved
@djshow832
Copy link
Contributor

@qw4990 Do you think it's OK to set factors to 0? Is it necessary to set scan factor to 0?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bf943d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@mmyj
Copy link
Member Author

mmyj commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

@mmyj: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@djshow832
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot
Copy link
Member

@mmyj: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@djshow832
Copy link
Contributor

/run-check_dev_2

@djshow832
Copy link
Contributor

/run-unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants