Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: try to fix some unstable test cases about partition table statistics #25026

Merged
merged 26 commits into from
Jun 3, 2021
Merged

planner: try to fix some unstable test cases about partition table statistics #25026

merged 26 commits into from
Jun 3, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 1, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: related to #24010, #24013, #24014, #24015, #24679

Problem Summary: planner: try to fix some unstable test cases about partition table statistics

What is changed and how it works?

No logical change, just create some separate DBs and tables for each test case to isolate their effect.

Check List

Tests

  • Unit test

Release note

  • planner: try to fix some unstable test cases about partition table statistics

@qw4990 qw4990 added the sig/planner SIG: Planner label Jun 1, 2021
@qw4990 qw4990 requested review from rebelice and time-and-fate June 1, 2021 08:39
@qw4990 qw4990 requested review from a team as code owners June 1, 2021 08:39
@qw4990 qw4990 requested review from XuHuaiyu and removed request for a team June 1, 2021 08:39
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 1, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jun 1, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88a64fc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/run-common-test
/run-integration-common-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/run-common-test
/run-integration-common-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/merge

2 similar comments
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 2, 2021

/merge

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/merge

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 80a2664

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/run-e2e-test

@qw4990
Copy link
Contributor Author

qw4990 commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 779abe5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@qw4990 qw4990 merged commit a37a30b into pingcap:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@rebelice rebelice rebelice approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @ti-chi-bot @rebelice @lzmhhh123 @ichn-hu