store/tikv/retry: make several BackoffType constants private #24654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/XL
Signed-off-by: shirly <AndreMouche@126.com>
AndreMouche
force-pushed
the
backoff/backofftype
branch
from
360e513 to
8d3f947
Compare
AndreMouche
requested review from
youjiali1995,
andylokandy,
disksing and
Rustin170506
sticnarf
approved these changes
May 14, 2021
| @@ -374,7 +374,7 @@ func (s *testStmtSummarySuite) TestAddStatement(c *C) { | |||
| expectedSummaryElement.sumPrewriteRegionNum += int64(stmtExecInfo3.ExecDetail.CommitDetail.PrewriteRegionNum) | |||
| expectedSummaryElement.sumTxnRetry += int64(stmtExecInfo3.ExecDetail.CommitDetail.TxnRetry) | |||
| expectedSummaryElement.sumBackoffTimes += 1 | |||
| expectedSummaryElement.backoffTypes[tikv.BoTxnLock] = 2 | |||
| expectedSummaryElement.backoffTypes[retry.BoTxnLock] = 2 | |||
There was a problem hiding this comment.
Wish we could get rid of this reference.
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
This PR will be closed since we find a better way to fix this situation #24692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AndreMouche
What problem does this PR solve?
This PR makes several constants
BackOffTypeprivate, so the caller needn't learn about theBackoffType, and also theBackoffTypeshould be an enum whilegolangdoesn't support, with this PR we can protect the newBackoffTypecreated by caller too.Part of #22513
Check List
Tests
Release note