-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: distinguish server timeout for TiKV and TiFlash #23700
tikv: distinguish server timeout for TiKV and TiFlash #23700
Conversation
/run-check_dev |
/run-all-tests |
/cc @hanfei1991 , @lzmhhh123 |
/cc @hanfei1991 |
/cc @lzmhhh123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some test cases?
Co-authored-by: djshow832 <zhangming@pingcap.com>
/lgtm |
/label type/bug-fix |
@LittleFall: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/type bug-fix |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a4f83b5
|
/label cherry-pick-approved |
@LittleFall: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/cc @zhouqiang-cl |
@LittleFall: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
|
What problem does this PR solve?
This pr is a follow-up of #21109
Problem Summary: Some TiFlash server time out still show
TiKV server timeout
.What is changed and how it works?
What's Changed:
Fix it in batch cop requests.
Related changes
pingcap/docs
/pingcap/docs-cn
: noCheck List
Tests
Side effects
Release note
TiKV server timeout
when executing TiFlash batch request.