-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: fix bug user privileges change after upgrade from 4.0.11 to 5.0 (#23403) #23527
session: fix bug user privileges change after upgrade from 4.0.11 to 5.0 (#23403) #23527
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
@tiancaiamao you're already a collaborator in bot's repo. |
/LTGM |
/cc @xhebox |
/rebuild |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 387541c
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #23403 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23527
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23387
Problem Summary:
#21856 introduce the problem, it adds
Repl_slave_priv
to all existing users while it should just do that for the root user.What is changed and how it works?
What's Changed:
Just assign the newly introduced privileges to the root user, rather than all existing users.
How it Works:
Make the behavior more acceptable when upgrading.
Related changes
Check List
Tests
Side effects
This just fix the code, if a user upgrades his cluster and meets the bug, he have to fix the data manually.
Release note
REPLICATION CLIENT
andREPLICATION
privileges unexpectedly.