Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partition: check partition definition with unsigned option (#23428) #23505

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #23385

  • partition check does not consider the unsigned flag
  • overflow on int column can be ignored such as create table t(a tinyint) partition by range(a) (partition p0 values less than (1234567));

Check List

Tests

  • Unit test

Release note

  • fix invalid partition can create success

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2021
@xiongjiwei
Copy link
Contributor Author

/type 5.0-cherry-pick

@xiongjiwei
Copy link
Contributor Author

/assign

@xiongjiwei
Copy link
Contributor Author

@ti-chi-bot
Copy link
Member

@xiongjiwei: GitHub didn't allow me to request PR reviews from the following users: crazycs520, AilinKid.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tangenta @AilinKid @tiancaiamao @crazycs520

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Mar 24, 2021
@wjhuang2016
Copy link
Member

@ti-chi-bot
Copy link
Member

@wjhuang2016: GitHub didn't allow me to request PR reviews from the following users: AilinKid, crazycs520.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tangenta @AilinKid @tiancaiamao @crazycs520

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2021
@zimulala
Copy link
Contributor

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2021
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 842cbd4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2021
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@AilinKid
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit b18eae9 into pingcap:release-5.0 Mar 24, 2021
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants