Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc: central GC mode is deprecated #23389

Merged
merged 4 commits into from
Mar 18, 2021
Merged

gc: central GC mode is deprecated #23389

merged 4 commits into from
Mar 18, 2021

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Mar 18, 2021

Signed-off-by: qupeng qupeng@pingcap.com

What problem does this PR solve?

TiKV 5.0 doesn't support central GC mode any more. So also deprecate it in TiDB.

What is changed and how it works?

Deprecate central GC mode.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

Release note

  • deprecated central GC mode

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@hicqu hicqu changed the title central GC mode is deprecated in v5.0 gc: central GC mode is deprecated in v5.0 Mar 18, 2021
@hicqu
Copy link
Contributor Author

hicqu commented Mar 18, 2021

/rebuild

@hicqu hicqu changed the title gc: central GC mode is deprecated in v5.0 gc: central GC mode is deprecated Mar 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@ti-chi-bot
Copy link
Member

@sticnarf: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sticnarf
sticnarf approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2021
@hicqu
Copy link
Contributor Author

hicqu commented Mar 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ebf66b

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Mar 18, 2021
@hicqu
return quickly
25c0222 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Mar 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 25c0222

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@hicqu
Copy link
Contributor Author

hicqu commented Mar 18, 2021

/merge

@hicqu
Copy link
Contributor Author

hicqu commented Mar 18, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 9f88887 into pingcap:master Mar 18, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 18, 2021
@hicqu @ti-srebot
cherry pick pingcap#23389 to release-5.0
93cd6d2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23393

@hicqu hicqu deleted the deprecate-central-gc branch March 18, 2021 07:03
ti-chi-bot pushed a commit that referenced this pull request Mar 19, 2021
@ti-srebot
gc: central GC mode is deprecated (#23389) (#23393)
f7a0e5b
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@hicqu @SabaPing
gc: central GC mode is deprecated (pingcap#23389)
4c94df6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@sticnarf sticnarf sticnarf approved these changes

Assignees
No one assigned
Labels
component/GC needs-cherry-pick-release-5.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hicqu @sre-bot @ti-chi-bot @ti-srebot @MyonKeminta @sticnarf @jackysp