planner: fix wrong index merge selection (#22825) #22924
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
sig/planner
|
@wjhuang2016 you're already a collaborator in bot's repo. |
|
/run-all-tests |
|
/cherry-pick-invite |
|
@wjhuang2016 you're already a collaborator in bot's repo. |
| rc := indexAccessPaths[i].CountAfterAccess | ||
| if rc < minEstRow { | ||
| minEstRowIndex = i | ||
| minEstRow = rc |
There was a problem hiding this comment.
Shall we cherry-pick the full changes of #23141 to this PR? otherwise the code / behavior may be different on 4.0 / master then.
There was a problem hiding this comment.
Ok, but the explain test is wrong, do you have any idea?
zhouqiang-cl
added
the
cherry-pick-approved
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 776dc1d
|
ti-chi-bot
added
the
status/can-merge
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-unit-tests |
cherry-pick #22825 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22924After apply modifications, you can push your change to this PR via:
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #22807
Problem Summary:
Previously we chose the index with the most columns, which is not accurate. We should use the index with the minimal estimated row count.
What is changed and how it works?
Choose the index with the minimal estimated row count for index merge.
Related changes
Check List
Tests
Side effects
Release note