Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load data bug #22742

Closed
wants to merge 1 commit into from
Closed

load data bug #22742

wants to merge 1 commit into from

Conversation

zoujia-cm
Copy link
Contributor

issue: #22735

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
When read data from file in client end, a '\n' will be add to the end of the byte array. This amy result to the exception of inserting last fields of the last terms.

What is changed and how it works?

Proposal: xxx

What's Changed:
delete '\n' at the end of the byte array while read data from client file

How it Works:
'\n' make the last field of the last term out of the format. after moving it, the problem can be resolved

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zoujia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Feb 5, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2021

@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what's changed

Or if the count of mainly changed packages are more than 3, use

  • *: what's changed

@zoujia-cm zoujia-cm closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants