-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, errno: make error code of ErrMixOfGroupFuncAndFields consistent with MySQL #22722
base: master
Are you sure you want to change the base?
Conversation
/run-all-tests |
@xuyifangreeneyes: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xuyifangreeneyes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@xuyifangreeneyes: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #22722 +/- ##
================================================
+ Coverage 77.1500% 77.1769% +0.0268%
================================================
Files 586 586
Lines 147646 147820 +174
================================================
+ Hits 113909 114083 +174
+ Misses 23488 23487 -1
- Partials 10249 10250 +1 |
xuyifan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
What problem does this PR solve?
Issue Number: close #22694
Problem Summary:
MySQL and TiDB report the same error about only_full_group_by check but give different error codes.
What is changed and how it works?
What's Changed & How it Works:
We remove
ErrMixOfGroupFuncAndFieldsIncompatible
(8123) and useErrMixOfGroupFuncAndFields
(1140) instead.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note