Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, errno: make error code of ErrMixOfGroupFuncAndFields consistent with MySQL #22722

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #22694

Problem Summary:
MySQL and TiDB report the same error about only_full_group_by check but give different error codes.

What is changed and how it works?

What's Changed & How it Works:
We remove ErrMixOfGroupFuncAndFieldsIncompatible(8123) and use ErrMixOfGroupFuncAndFields(1140) instead.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • make error code of ErrMixOfGroupFuncAndFields consistent with MySQL

@xuyifangreeneyes xuyifangreeneyes requested a review from a team as a code owner February 4, 2021 05:26
@xuyifangreeneyes xuyifangreeneyes requested review from XuHuaiyu and removed request for a team February 4, 2021 05:26
@xuyifangreeneyes
Copy link
Contributor Author

/run-all-tests

@ichn-hu ichn-hu mentioned this pull request Feb 5, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021
@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 02:41
@xuyifangreeneyes
Copy link
Contributor Author

/cc @winoros @AilinKid

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 6, 2023

@xuyifangreeneyes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test adb7015 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot
Copy link
Member

@xuyifangreeneyes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test adb7015 link true /test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.1769%. Comparing base (9e3c064) to head (adb7015).
Report is 12346 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #22722        +/-   ##
================================================
+ Coverage   77.1500%   77.1769%   +0.0268%     
================================================
  Files           586        586                
  Lines        147646     147820       +174     
================================================
+ Hits         113909     114083       +174     
+ Misses        23488      23487         -1     
- Partials      10249      10250         +1     

@sre-bot
Copy link
Contributor

sre-bot commented Aug 16, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


xuyifan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmatched error code with MySQL for a same error (only_full_group_by)
3 participants